-
-
Notifications
You must be signed in to change notification settings - Fork 408
Use goreleaser to build the full binary matrix #311
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
## Legal requirements | ||
|
||
Before we can accept your contributions you have to sign the [Contributor License Agreement][0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we going to use cla-assistant for it, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, already in place, included Github integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, especially on the CONTRIBUTING.md
This PR adds a Dockerfile used to build an image capable to cross compile the CLI for all the supported platforms:
NOTE this is highly WIP work, because of https://bugs.launchpad.net/ubuntu/+source/gcc-defaults/+bug/1300211 the image doesn't work ootb. Currently trying to build from https://github.com/multiarch/crossbuild instead ofgolang-cross
.This PR supersedes #120 and partially #132 (the binary provided is static for any platform except Darwin)
TODO: