Skip to content

Use goreleaser to build the full binary matrix #311

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 12 commits into from
Jul 31, 2019
Merged

Conversation

masci
Copy link
Contributor

@masci masci commented Jul 26, 2019

This PR adds a Dockerfile used to build an image capable to cross compile the CLI for all the supported platforms:

  • arduino-cli_0.3.7-alpha.preview-next_Linux_32bit.tar.gz
  • arduino-cli_0.3.7-alpha.preview-next_Linux_64bit.tar.gz
  • arduino-cli_0.3.7-alpha.preview-next_Linux_ARM64.tar.gz
  • arduino-cli_0.3.7-alpha.preview-next_Linux_ARMv7.tar.gz
  • arduino-cli_0.3.7-alpha.preview-next_Windows_32bit.zip
  • arduino-cli_0.3.7-alpha.preview-next_Windows_64bit.zip
  • arduino-cli_0.3.7-alpha.preview-next_macOS_64bit.tar.gz

NOTE this is highly WIP work, because of https://bugs.launchpad.net/ubuntu/+source/gcc-defaults/+bug/1300211 the image doesn't work ootb. Currently trying to build from https://github.com/multiarch/crossbuild instead of golang-cross.

This PR supersedes #120 and partially #132 (the binary provided is static for any platform except Darwin)

TODO:

  • Build and make the Docker image available through Docker Hub
  • Add a step to the CI to invoke goreleaser
  • Integrate with Github
  • Cleanup

@masci masci marked this pull request as ready for review July 29, 2019 08:07
masci and others added 3 commits July 30, 2019 11:49
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
Co-Authored-By: per1234 <accounts@perglass.com>
@per1234 per1234 dismissed their stale review July 30, 2019 09:53

Requested changes have been made. Thanks!

Copy link
Contributor

@gvarisco gvarisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## Legal requirements

Before we can accept your contributions you have to sign the [Contributor License Agreement][0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going to use cla-assistant for it, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, already in place, included Github integration

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, especially on the CONTRIBUTING.md

@masci masci merged commit 6e7e8d1 into master Jul 31, 2019
@masci masci deleted the massi/gorelaser branch July 31, 2019 07:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants