Fix cached build #367
Merged
Fix cached build #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in build options This is accomplished by updating go-properties-orderedmap with this fix: arduino/go-properties-orderedmap@05018b2
This commit should be equivalent, no semantic changes just simplified the notation.
facchinm
approved these changes
Aug 28, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a bug in the properties map checking, the "build options" resulted always "changed" resulting in a full rebuild every time.
The real fix is in the update of the library go-properties-orderedmap.
The rest of the patch is just cosmetic.