Skip to content

Fix panic on missing sketch path #432

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

Fix panic on missing sketch path #432

merged 1 commit into from
Oct 1, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Oct 1, 2019

Fixes #165

@masci masci added this to the 0.6.0 milestone Oct 1, 2019
rsora
rsora approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@masci masci merged commit 3dcbb9b into master Oct 1, 2019
@masci masci deleted the massi/165 branch October 1, 2019 09:08
cmaglie
cmaglie reviewed Oct 1, 2019
View reviewed changes
cli/board/attach.go
path = args[1]

var path *paths.Path
if len(args) > 1 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm.. shouldn't be > 0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, forget it, 1 is correct.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cmaglie cmaglie cmaglie left review comments

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

SIGSEGV running 'board attach' with fqbn in 0.3.6-alpha.preview
3 participants
@masci @cmaglie @rsora