Skip to content

Fix bashisms in install.sh #440

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2019
Merged

Fix bashisms in install.sh #440

merged 1 commit into from
Oct 14, 2019

Conversation

shimon1024
Copy link
Contributor

[ ... == ... ] is Bash extension. install.sh should use syntax of standard test command.

@shimon1024
Fix bashisms in install.sh
cfd9a4d 
`[  ... == ...  ]` is Bash extension. install.sh should use syntax of
standard `test` command.
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

matthijskooijman
matthijskooijman approved these changes Oct 12, 2019
View reviewed changes
Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, but the change looks good to me.

@masci masci merged commit d9504b6 into arduino:master Oct 14, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthijskooijman matthijskooijman matthijskooijman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shimon1024 @CLAassistant @matthijskooijman @masci