Fixed upload issue on esp32 (partitions artifacts copy) #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the compile command copied only the following artifacts: sketch.ino.hex (or .bin) sketch.ino.elf now also the files matching the glob sketch.ino.*.hex will be copied. This allows for some 3rd party core (like esp32) to copy also the extra file sketch.ino.partitions.bin. Should fix #163
cmaglie
force-pushed
the
cmaglie/fix-esp32-build-artifacts-copy
branch
from
20d15ce to
09e3c42
Compare
|
Works great for me. |
cmaglie
changed the title
per1234
added
topic: code
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the compile command copied only the following artifacts:
now also the files matching the glob
will be copied.
This allows for some 3rd party core, like esp32, to copy also extra files like
sketch.ino.partitions.bin.Should fix #163