Skip to content

Avoid panics when compiling for custom boards #491

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Avoid panics when compiling for custom boards #491

merged 1 commit into from
Nov 28, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Nov 20, 2019

Fixes #177

When working with custom boards some corner cases might arise and provide an inconsistent in-memory representation of the cores. This PR introduces more checks for structs and fields that might be nil at some point during compilation.

@masci masci added this to the 0.7.0 milestone Nov 20, 2019
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast LGTM

@masci masci merged commit da8fc05 into master Nov 28, 2019
@masci masci deleted the massi/177 branch November 28, 2019 14:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV when compiling for custom boards
2 participants