Restore permission lost during upload/download #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
GitHub Actions does not preserve file permission when a file is shared between jobs as an artifact using the upload-artifact@v1 and download-artifact@v1 actions.
I have empirically observed this behavior in a test workflow, and I've found a few issues on GitHub.
According to a comment from a user, GitHub will fix this file permission issue in the v2 version of these actions.
Change description
Execution permission is re-added using
chmod, until this problem is fixed in the actions.Additional Notes
User reported bugs:
Reviewer checklist
master.CONTRIBUTING.md) and are well formatted.