Skip to content

Remove upload port as required CLI parameter in "upload" command #608

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2020
Merged

Remove upload port as required CLI parameter in "upload" command #608

merged 2 commits into from
Mar 6, 2020

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Mar 6, 2020 •
edited
Loading

This PR follows #454 and:

  • removes upload port as required CLI parameter in upload command to support board attach generated sketch.json file
  • adds a board attach integ test

@rsora rsora merged commit 8483cb2 into master Mar 6, 2020
@rsora rsora deleted the rsora/upload-port branch March 6, 2020 12:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsora @masci