Skip to content

legacy removing: small advances (1st chunk of #481) #627

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Apr 8, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 20, 2020

Since #481 is very big and it's not getting reviewed, I'm trying to split in smaller chuncks, hopefully it would get in quicker.

cmaglie added 4 commits March 19, 2020 17:57
Possibly a container structure for build properties may be defined later
with helper methods (like GetBuildCorePath() ... etc.) to help in
retrieving these properties.
@cmaglie cmaglie requested review from facchinm and rsora March 20, 2020 10:58
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmaglie cmaglie merged commit 5b805dd into arduino:master Apr 8, 2020
@cmaglie cmaglie deleted the legacy-remove-1 branch April 8, 2020 15:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants