Skip to content

Add checksum check before installing a package #947

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Add checksum check before installing a package #947

merged 1 commit into from
Sep 15, 2020

Conversation

rhaidiz
Copy link

@rhaidiz rhaidiz commented Sep 14, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Add check of the package checksum when installing a package.
  • What is the current behavior?
    No check on the checksum is performed.
  • What is the new behavior?
    The checksum is checked before installing a new package.

See how to contribute

@rhaidiz
Copy link
Author

rhaidiz commented Sep 14, 2020

Note: since this PR adds an integrity verification when installing a package, and since the checksum and size of the core.zip file in test_index.json in the master repository is wrong, some integration tests fail.

@rsora
Copy link
Contributor

rsora commented Sep 15, 2020

@rhaidiz could you please rebase this PR on master to get the latest changes?

@rhaidiz
Copy link
Author

rhaidiz commented Sep 15, 2020

Sure, PR rebased.

@rsora rsora merged commit 163a1f7 into arduino:master Sep 15, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants