Use SafeJoin in the uploadHandler #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio-perugini
added
topic: code
alessio-perugini
force-pushed
the
use-safe-join
branch
from
11d3ceb to
415f238
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 16.85% 17.76% +0.91%
==========================================
Files 53 53
Lines 4082 4103 +21
==========================================
+ Hits 688 729 +41
+ Misses 3294 3270 -24
- Partials 100 104 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
👀 |
rhpco
approved these changes
Sep 5, 2023
rhaidiz
approved these changes
Sep 12, 2023
cmaglie
reviewed
Sep 12, 2023
Comment on lines
+153
to
+164
| // SafeJoin performs a filepath.Join of 'parent' and 'subdir' but returns an error | ||
| // if the resulting path points outside of 'parent'. | ||
| func SafeJoin(parent, subdir string) (string, error) { | ||
| res := filepath.Join(parent, subdir) | ||
| if !strings.HasSuffix(parent, string(os.PathSeparator)) { | ||
| parent += string(os.PathSeparator) | ||
| } | ||
| if !strings.HasPrefix(res, parent) { | ||
| return res, fmt.Errorf("unsafe path join: '%s' with '%s'", parent, subdir) | ||
| } | ||
| return res, nil | ||
| } |
There was a problem hiding this comment.
Maybe this could be a good candidate for go-paths-helper
There was a problem hiding this comment.
alessio-perugini
force-pushed
the
use-safe-join
branch
from
e523731 to
3929fea
Compare
alessio-perugini
force-pushed
the
use-safe-join
branch
from
3929fea to
139ce6b
Compare
ghost
mentioned this pull request
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://arduino.atlassian.net/browse/PNX-1543
Fixes: https://arduino.atlassian.net/browse/PNX-4130 (e523731)