-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix memory leak #837
fix memory leak #837
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 17.76% 18.37% +0.60%
==========================================
Files 53 53
Lines 4103 4120 +17
==========================================
+ Hits 729 757 +28
+ Misses 3270 3257 -13
- Partials 104 106 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hello @thechampagne, thanks for your contribution! Could you please add a bit more context to this? It would make the review process a lot faster. |
Hello @thechampagne, one last thing, and I think we are ready to merge: could you please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this on Mac OS Ventura.
The app is able to generate certificates once the password is correctly entered by the user.
(it prompts for it)
Please check if the PR fulfills these requirements
before creating one)