Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Large file crashes IDE when pushing to Remote Sketchbook #634

Closed
ubidefeo opened this issue Nov 26, 2021 · 3 comments · Fixed by #1910
Closed

Large file crashes IDE when pushing to Remote Sketchbook #634

ubidefeo opened this issue Nov 26, 2021 · 3 comments · Fixed by #1910
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved criticality: low Of low impact priority: medium Resolution is a medium priority topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@ubidefeo
Copy link

ubidefeo commented Nov 26, 2021 •
edited
Loading

Describe the bug
When using the Remote Sketchbook feature to push and sync Sketches across IDE 2.0 and Arduino Cloud,
If I add a file above 100KB (could be a font or image byte array file), the IDE's window crashes and the IDE stops working.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Remote Sketchbook
  2. # if you are not
  3. Pull a Sketch if you haven't
  4. Sketch > Show Sketch Folder
  5. add any small file (could be a .h or your own .h/.cpp Class
  6. Push
  7. It will work
  8. Add a larger file (> 100KB) such as a custom font or image converted to Bitmap
  9. Push
  10. IDE will crash (see screenshot)

Expected behavior
Either issue a warning or fix the upload limit

Screenshots
screen recording

Desktop (please complete the following information):

  • OS: Mac OS
  • Version: 2.0.0 Beta 12 (any)

Find attached a sample converted font
Orbitron_Medium_20.h.zip
@ubidefeo ubidefeo added priority: medium Resolution is a medium priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project criticality: low Of low impact labels Nov 26, 2021
@AlbyIanna AlbyIanna mentioned this issue Nov 29, 2021
Closed
@fstasi
Copy link
Contributor

fstasi commented Nov 29, 2021

@ubidefeo seems like it crashes when a new file (not on cloud) is pushed. Size seems not related based on @AlbyIanna investigation.

@per1234 per1234 linked a pull request Nov 30, 2021 that will close this issue
Prevent from pushing files that are bigger than 100 KB #639
Closed
@AlbyIanna AlbyIanna removed their assignment Nov 30, 2021
@fstasi fstasi assigned AlbyIanna and unassigned fstasi Dec 1, 2021
@AlbyIanna AlbyIanna mentioned this issue Dec 20, 2021
Merged
@fstasi fstasi closed this as completed Dec 20, 2021
@ubidefeo
Copy link
Author

tested and working

@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Feb 20, 2022
@kittaakos
Copy link
Contributor

Moved from here:

I have noticed IDE 2.0.3 crashes when I pull such a sketch:

I downloaded the problematic sketch from Create:

sketch_feb14c.zip

ide-crash.mp4

@kittaakos kittaakos reopened this Feb 22, 2023
@kittaakos kittaakos assigned kittaakos and unassigned AlbyIanna Feb 22, 2023
@kittaakos kittaakos removed the conclusion: invalid Issue/PR not valid label Feb 22, 2023
This was referenced Feb 22, 2023
Open
Closed
kittaakos pushed a commit that referenced this issue Feb 22, 2023
fix: encoding when reading a cloud sketch
402a7e7 
Closes #449
Closes #634

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this issue Feb 22, 2023
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Feb 23, 2023
fix: encoding when reading a cloud sketch
23906d9 
Closes #449
Closes #634

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Feb 23, 2023
fix: encoding when reading a cloud sketch
3f5eddb 
Closes #449
Closes #634

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Feb 24, 2023
fix: encoding when reading a cloud sketch
eca7922 
Closes #449
Closes #634

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Mar 3, 2023
kittaakos pushed a commit that referenced this issue Mar 9, 2023
fix: encoding when reading a cloud sketch
07f08f8 
Closes #449
Closes #634

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the topic: cloud Related to Arduino Cloud and cloud sketches label Mar 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved criticality: low Of low impact priority: medium Resolution is a medium priority topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
5 participants
@kittaakos @fstasi @ubidefeo @AlbyIanna @per1234