Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: refresh the user-fields at app startup #2234

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: refresh the user-fields at app startup #2234

merged 1 commit into from
Sep 26, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

After #2165, there are no artificial board+port change events in IDE2 at startup. Hence, if the port and board have been set in a previous IDE2 session, no board+port change occurs at the next startup. This PR patches the user-field behavior and makes sure to retrieve the board+port.

Change description

Other information

Ref: #2165
Closes #2230

Related:

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Ref: #2165
Closes #2230

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 21, 2023
@kittaakos kittaakos self-assigned this Sep 21, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #2230

Thanks Akos!

@kittaakos kittaakos marked this pull request as ready for review September 26, 2023 07:43
@kittaakos kittaakos merged commit 7f660d7 into main Sep 26, 2023
@kittaakos kittaakos deleted the #2230 branch September 26, 2023 07:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot perform ota update after ota credentials changed
2 participants