Skip to content

fix: use board+port at startup if it's restored #2242

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 5, 2023
Merged

fix: use board+port at startup if it's restored #2242

merged 4 commits into from
Oct 5, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Sep 29, 2023 •
edited
Loading

Motivation

There are a few regressions in IDE2 after the board+port simplification (#2165). This PR fixes them.

Change description

Refresh the following at app startup when the board+port selection has been restored:

  • the board+port in the status bar. (this is not a functional bug, but with db83ed0, an unnecessary refresh has been removed),
  • File > Examples menu (20a192a),
  • Sketch > Include Library menu (20a192a),
  • Debug toolbar item (4d04aac)

Steps to verify:

  1. Open IDE2,
  2. Create a new sketch and save it,
  3. Select your Arduino Nano ESP32 board (you can select any other board that supports debugging),
  4. Verify
    • the debug toolbar is enabled,
    • File > Examples > Examples for Arduino Nano ESP32 menu group is visible,
    • Sketch > Include Library > Arduino libraries menu group is visible.
  5. Quit IDE2,
  6. Start IDE2,
  7. Repeat step (4); all works.
Screenshot 2023-10-02 at 09 25 50 Screenshot 2023-10-02 at 09 26 01 Screenshot 2023-10-02 at 09 26 09

Other information

Closes #2237
Closes #2239

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Akos Kitta added 4 commits September 29, 2023 11:33
fix: update status bar if board+port restored
db83ed0 
This is not a functional bug, as this component listens on board list
changes, but no unnecessary refresh is needed.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
fix: refresh debug state if board+port is restored
4d04aac 
Closes #2237

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
fix: init Include Library if board+port is ready
20a192a 
Closes #2239

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
fix: init library examples if board+port is ready
4a8740d 
Closes #2239

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 29, 2023
@kittaakos kittaakos self-assigned this Sep 29, 2023
@kittaakos kittaakos marked this pull request as ready for review October 2, 2023 07:31
@kittaakos kittaakos requested a review from per1234 October 2, 2023 07:31
per1234
per1234 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #2237 and
#2239

Thanks Akos!

@kittaakos kittaakos merged commit 57975f8 into main Oct 5, 2023
@kittaakos kittaakos deleted the #2239 branch October 5, 2023 12:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
2 participants
@kittaakos @per1234