Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: memory leak when scanning sketchbooks with large files #2555

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: memory leak when scanning sketchbooks with large files #2555

merged 1 commit into from
Nov 21, 2024

Conversation

giacomocusinato
Copy link
Collaborator

@giacomocusinato giacomocusinato commented Nov 8, 2024 •
edited
Loading

Motivation

Change description

Update glob version to fix memory leak issue
See isaacs/node-glob#435
Use glob version 10 as the highest compatible with IDE node version

Other information

Closes #2537

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@giacomocusinato giacomocusinato changed the title core: upgrade node-glob library fix: memory leak issue when scanning sketches Nov 8, 2024
@giacomocusinato giacomocusinato force-pushed the #2537 branch 3 times, most recently from 0448010 to 84245dd Compare November 8, 2024 18:44
@giacomocusinato giacomocusinato marked this pull request as ready for review November 8, 2024 18:49
@giacomocusinato giacomocusinato added the topic: code Related to content of the project itself label Nov 8, 2024
@giacomocusinato giacomocusinato changed the title fix: memory leak issue when scanning sketches fix: memory leak when scanning sketchbooks with large files Nov 8, 2024
@giacomocusinato
fix: update glob version to fix memory leak
18e2ac1 
Resolves #2537

Fix memory leak issue caused by inflight dependency, see isaacs/node-glob#435
@giacomocusinato giacomocusinato added the type: imperfection Perceived defect in any part of project label Nov 20, 2024
@davegarthsimpson davegarthsimpson merged commit 7c231ff into main Nov 21, 2024
28 checks passed
@davegarthsimpson davegarthsimpson deleted the #2537 branch November 21, 2024 07:40
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Dec 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE freezes and goes offline when large folder is present in sketchbook
3 participants
@giacomocusinato @davegarthsimpson @per1234