Open Save as... dialog when saving sketches for the first time #579
Conversation
Without this fix, sketches report their URI path as /private/var/xxx whereas `os.tmpdir()` returns /var/xxx. The second path can be turned into the first by resolving symlinks, which gives a canonical path to compare against.
per1234
added
topic: code
rsora
changed the title
|
This also fixes saving opened examples. We'll do a code review and get back to you asap ✌️ |
There was a problem hiding this comment.
I tried it out and it works just as expected for me. Thanks @federicobond!
|
@federicobond Thanks for your contribution! I was checking the behavior when autosave is on and you try to close a newly created or example sketch: it works as expected on |
|
@91volt I could not reproduce that. I'm seeing the Are you sure you want to close this sketch? dialog in both cases, with Yes/No buttons. |
|
@federicobond Are you sure auto save is enabled? |
|
@91volt interesting... I think it's a bit different problem, so if there aren't any other objections I would prefer to keep that fix out of the scope of this pull request. I might take a look at it later. |
|
@federicobond thanks for checking it, I guess you are right, I'm gonna add a separate issue for that. |
There was a problem hiding this comment.
LGTM ✨
✅ Code review
@federicobond Thank you so much for contributing, your help is very useful and very very much appreciated 😉
Closes #64
This is my first contribution to arduino-ide, please let me know if anything is missing.