Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix tabs ordering #612

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Fix tabs ordering #612

merged 1 commit into from
Nov 23, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Nov 16, 2021

Why

After the latest Theia inclusion, tabs order gets scrambled. This is particularly true when the Sketch has multiple .ino files and/or a file different from the main .ino file was selected the last time the sketch was opened

How

  • Changed the cleanup script that finds duplicated tabs in monaco
  • removed the now useless force open on the main .ino file. This was actually causing the issue as forcing the open of the file that was already opened caused the close of the original one and a new open in the last position

@fstasi fstasi requested a review from AlbyIanna November 16, 2021 21:32
@fstasi fstasi mentioned this pull request Nov 16, 2021
Closed
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 17, 2021
@ubidefeo ubidefeo self-requested a review November 18, 2021 14:25
ubidefeo
ubidefeo approved these changes Nov 18, 2021
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct behaviour has been restored.
LGTM

@per1234 per1234 linked an issue Nov 18, 2021 that may be closed by this pull request
The first time you run it, the other files in the project will not load (tabs) #541
Closed
@ubidefeo
Copy link

I have reviewed/approved the PR
cc @per1234

@fstasi fstasi merged commit 9863dc2 into main Nov 23, 2021
@fstasi fstasi deleted the tabs-order branch November 23, 2021 11:16
@kittaakos kittaakos mentioned this pull request Jun 10, 2022
Closed
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

@ubidefeo ubidefeo

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The first time you run it, the other files in the project will not load (tabs)
3 participants
@fstasi @ubidefeo @per1234