Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix notification icons #642

Merged
merged 1 commit into from
Nov 30, 2021
Merged

fix notification icons #642

merged 1 commit into from
Nov 30, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Nov 30, 2021

Why

Notifications have broken icons

How

Use codicons to restore icons in the notification center

fixes #531

@fstasi fstasi requested a review from AlbyIanna November 30, 2021 16:05
AlbyIanna
AlbyIanna approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fstasi fstasi merged commit f0d9894 into main Nov 30, 2021
@fstasi fstasi deleted the fix-notification-icons branch November 30, 2021 16:24
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification clear control is invisible
3 participants
@fstasi @AlbyIanna @per1234