Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix board options not shown for manually installed platforms #826

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Fix board options not shown for manually installed platforms #826

merged 1 commit into from
Feb 14, 2022

Conversation

silvanocerza
Copy link
Contributor

Fixes #565.

Before:

before

After:

after

@silvanocerza silvanocerza added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 11, 2022
@silvanocerza silvanocerza self-assigned this Feb 11, 2022
@silvanocerza silvanocerza added this to the arduino-ide rc4 milestone Feb 11, 2022
@silvanocerza silvanocerza force-pushed the scerza/fix-missing-properties branch from 516a48a to 04b72ef Compare February 11, 2022 15:42
@silvanocerza
Copy link
Contributor Author

@ubidefeo tested and the previous solution wasn't working for manually installed platform that didn't have version set in their platform.txt so I had to make some changes.

Another review is required I think. @fstasi

per1234
per1234 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#565 no longer occurs for me when using this build.

Thanks Silvano!

@ubidefeo
Copy link

Works as expected
thank you

@silvanocerza silvanocerza merged commit 877c1a1 into main Feb 14, 2022
@silvanocerza silvanocerza deleted the scerza/fix-missing-properties branch February 14, 2022 09:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fstasi fstasi fstasi approved these changes

@per1234 per1234 per1234 approved these changes

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

@silvanocerza silvanocerza

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing board option and Programmer menus for manually installed platforms
4 participants
@silvanocerza @ubidefeo @fstasi @per1234