Go to download page when automatic update fails #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstasi
approved these changes
Feb 28, 2022
per1234
added
topic: code
per1234
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
I tested under the following conditions:
- Download fails due to a 404
- Download fails due to using the
.zipLinux build (which doesn't support auto-update)
Previously, either of these conditions resulted in the update download dialog hanging at 0%, with no feedback unless you checked the command line output (and even that wasn't clear in the case of using the .zip Linux build).
Now both of these situations are handled gracefully by the IDE.
Thanks Alberto!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Errors happening during the automatic update aren't handled properly.
Change description
Whenever an error happens during the automatic update occurs, show a link to the download page to let the user download the IDE by themselves.
Reviewer checklist