Improve condition to recognise read-only sketches #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Yes it fixes #917. As per #866, no, this PR only concerns read-only files that cannot be edited, and not read-only files that cannot be closed. Anyway, I believe #866 has already been fixed in another PR. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
AlbyIanna
force-pushed
the
read-only-iot-sketches
branch
from
ede63f6 to
c0c257e
Compare
per1234
requested changes
Apr 6, 2022
arduino-ide-extension/src/common/protocol/sketches-service-client-impl.ts
Outdated
Show resolved
Hide resolved
It has not been fixed:
|
AlbyIanna
force-pushed
the
read-only-iot-sketches
branch
from
c0c257e to
180b0fa
Compare
per1234
approved these changes
Apr 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The condition to check if a sketch must be shown in read-only mode is too mild. For example, a
thingProperties.hfile shouldn't be read-only if it's not inside an IoT sketchChange description
Check if it's an IoT sketch.
Reviewer checklist