Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Specify Node.js 16.x runtime for action execution in runner #193

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Specify Node.js 16.x runtime for action execution in runner #193

merged 1 commit into from
Oct 27, 2022

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Oct 27, 2022

The Node.js version for use when executing the action in the GitHub Actions runner is configured via the runs.using field of the action.yml metadata file.

Previously, the action was configured to use Node.js 12.x. This was actually the result of an oversight, as Node.js 16.x has been used for the development and validation of the action since 2022-01-11 (#42). It will be important to use the same version on the runner as the action is validated for by the project infrastructure in order to ensure the expected behavior.

In addition, GitHub has deprecated the use of Node.js 12.x runtime. A warning about this was shown in the workflow run summary page of all workflows using this action (#182). That warning will be resolved, and the eventual complete breakage of those workflows avoided, by this change.


Fixes #182

The Node.js version for use when executing the action in the GitHub Actions runner is configured via the `runs.using`
field of the `action.yml` metadata file.

Previously, the action was configured to use Node.js 12.x. This was actually the result of an oversight, as Node.js 16.x
has been used for the development and validation of the action since 2022-01-10. It will be important to use the same
version on the runner as the action is validated for by the project infrastructure in order to ensure the expected
behavior.

In addition, GitHub has deprecated the use of Node.js 12.x runtime. A warning about this was shown in the workflow run
summary page of all workflows using this action. That warning will be resolved, and the eventual complete breakage of
those workflows avoided, by this change.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Oct 27, 2022
@per1234 per1234 self-assigned this Oct 27, 2022
Copy link

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Per!

@per1234 per1234 merged commit 36f5973 into arduino:main Oct 27, 2022
@RobTillaart
Copy link

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node12 is depreciated => use node16 instead
3 participants