-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
A lightweight library based on JSON and Network Sockets for Arduino communication and control based configured by a Manifesto. #6332
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
A problem was found with your submission https://github.com/ruiseixasm/JsonTalkie ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
Thanks for your interest in contributing to the Arduino Library Manager index @ruiseixasm After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
The file requested is inside |
I added the folder |
Hello! I'm checking your submission again. |
A problem was found with your submission https://github.com/ruiseixasm/JsonTalkie ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
Thanks for your interest in contributing to the Arduino Library Manager index @ruiseixasm After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file requested is inside Arduino/JsonTalkie folder!
Hello @ruiseixasm. You neglected to follow step 1 in the instructions:
- You may want to first take a look at the requirements for admission into the Arduino Library Manager index. Each submission will be checked for compliance before being accepted.
If you check the requirements, you will see this:
- The library.properties file must be located in the root of the repository.
So you must move the Arduino library to the root of the current repository if you want to add it to Arduino Library Manager.
If you want to keep a clear separation between the Arduino library and the Python scripts, you could use a separate repository for each of them, with one library dedicated exclusively to the Arduino library, and another dedicated exclusively to the Python code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ruiseixasm. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/ruiseixasm/JsonTalkie/tree/1.1.0
(note that the library is still under the Arduino
subfolder of the repository at the tagged point in the revision history)
❗ Remember to update the version
field in the library's library.properties
file as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
Hello! I'm checking your submission again. |
Arduino Lint has suggestions for possible improvements to https://github.com/ruiseixasm/JsonTalkie:
|
Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index. The library(s) will be available for installation via Library Manager within a day's time. You can check the logs from the Library Manager indexer for your library(s) here: |
Repository: https://github.com/ruiseixasm/JsonTalkie
Library folder: Arduino/JsonTalkie