Use pushOnce builtin, remove custom pushonce directive #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ve also opened a PR for Laravel, though it can’t have any bearing on this PR unless it is also merged into 9.x. |
mikerockett
force-pushed
the
patch-for-2300
branch
from
a4bfc69 to
d44f4ad
Compare
ifox
approved these changes
Jan 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the custom
pushonceBlade directive, and uses thepushOncedirective baked into Laravel 9 and 10 instead.In order to reduce the chances of a sub-stack
$idcollision, I have prepended the two usages withform:. Perhaps it might be a good idea for me to open a PR against Laravel, which does not check if an$idis used in a specific stack, but rather across all stacks, which I don't think makes a lot of sense.Related Issues
Resolves #2300