Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix:bug preserve default vselect value when undefined #2311

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Conversation

bwat-dev
Copy link
Contributor

Description

Filters select :
When clearing filters the select loses its default value, and the field displays an empty select :

Capture d’écran 2023-07-30 à 12 20 07

Copy link
Member

@ifox ifox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bwat-dev! Submitted a few cleanup changes but otherwise should be good to go.

@bwat-dev bwat-dev requested a review from ifox August 1, 2023 18:16
@ifox ifox merged commit 689aa86 into area17:3.x Jan 16, 2024
ifox added a commit that referenced this pull request Jan 25, 2024
* Update VSelect updateValue method to prevent value being selected more than once

* Fix VSelect button styles

* Revert random padding value change in _vselect.scss

* Correct _vselect.scss for 3.x

* Fix vselect button position

* Fix merge with #2311

* Fix selected option padding for table filters

---------

Co-authored-by: Quentin Renard <quentin@area17.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants