Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Respect skipSpecialTokens option in the decodingCallback function #115

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

shawiz
Copy link
Contributor

@shawiz shawiz commented Apr 13, 2024

I want to show the live transcription process as the transcription happens, and don't want it to show special characters. Right now, regardless of how you set skipSpecialTokens in the decoder options, it will include special characters in the decodingCallback function under .text. I fixed that so it follows the skipSpecialTokens option. I've verified it in the WhisperAX app.

@atiorh
Copy link
Contributor

atiorh commented Apr 13, 2024

Thanks @shawiz ! I will let @ZachNagengast chime in. On a separate note, we are currently lowering the "Eager mode" from the app layer down to the library so it can be built on without extra user code. Just mentioning it now, in case you had to rewrite or copy-paste code to use it so far.

Copy link
Contributor

@ZachNagengast ZachNagengast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for the contribution!

@ZachNagengast ZachNagengast merged commit 8564ce2 into argmaxinc:main Apr 14, 2024
5 of 6 checks passed
@shawiz
Copy link
Contributor Author

shawiz commented Apr 15, 2024

Thanks guys!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants