-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixed tokenizer and audio processing logic #214
Open
1amageek
wants to merge
27
commits into
argmaxinc:main
Choose a base branch
from
1amageek:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c53d130
Update dependencies and fix language detection typo
1amageek 2608340
Update AudioEncoder shape access and add tokenizer methods
1amageek b8029fb
Add `Sendable` conformance to several structs and enums
1amageek 2af7d50
Refactor AudioProcessor to use actor model and async
1amageek dd1c4d5
Add Sendable conformance to various types and protocols
1amageek 208893d
Update development team and package dependencies
1amageek 9539e8b
Update package version and clean up code formatting
1amageek 769dc29
Refactor audio energy calculations and buffer conversion
1amageek c8219d3
Refactor calculateRelativeEnergy method for clarity
1amageek 2c0549c
Optimize audio buffer processing with vDSP_mmov
1amageek 22aaa70
Refactor audio sample access methods in AudioProcessor
1amageek 8ceaa0a
Remove unnecessary weak self references in closure
1amageek 4d4233e
Refactor audio processing to use async/await methods
1amageek f9bcd1d
Use weak self in audio tap closure to prevent retain cycle
1amageek ea5d853
Log file name in error message for transcriber
1amageek 5909d11
Refactor VADAudioChunker to a struct from a class
1amageek 184b990
Refactor voice activity detection to use protocols
1amageek 933b71b
Add audio converter initialization in resampling process
1amageek 2dbb87f
Refactor AudioProcessor to use SampleRange type
1amageek 368333f
Make AudioProcessing conform to Actor protocol
1amageek c41fb22
Refactor SegmentSeeker to improve readability and performance
1amageek 621b1f3
Refactor SegmentSeeker to improve clarity and efficiency
1amageek f646268
Refactor SegmentSeeker to simplify alignment handling
1amageek db66166
Refactor SegmentSeeker to handle Float16 data type
1amageek 28f34c3
Remove unnecessary comments in SegmentSeeker.swift
1amageek bb66ae1
Refactor SegmentSeeker for improved clarity and performance
1amageek 8bfdd88
Refactor audio processor deinit and improve memory management
1amageek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shape[0]: Batch size
shape[1]: Sequence length
shape[2]: Embedding dimension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1amageek I don't think this is right: https://huggingface.co/argmaxinc/whisperkit-coreml/blob/main/openai_whisper-base/AudioEncoder.mlmodelc/metadata.json#L59