fix: Pass AppNamespace to UpdateSpec api call #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 66.27% 66.29% +0.01%
==========================================
Files 22 22
Lines 2150 2151 +1
==========================================
+ Hits 1425 1426 +1
Misses 591 591
Partials 134 134 ☔ View full report in Codecov by Sentry. |
mwijngaard
force-pushed
the
add-appnamespace-to-update-spec
branch
from
2a08935
to
8211270
Compare
…other namespaces than argocd itself (when using the argocd api). Signed-off-by: Merijn Wijngaard <mwijngaard@gmail.com>
mwijngaard
force-pushed
the
add-appnamespace-to-update-spec
branch
from
8211270
to
133a3da
Compare
|
Any chance this could get merged? |
jannfis
changed the title
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Merijn Wijngaard <mwijngaard@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for applications in other namespace than default argocd namespace (when using the argocd api).