Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue regarding volume added in #710 #750

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fix issue regarding volume added in #710 #750

merged 1 commit into from
Jun 19, 2024

Conversation

subigre
Copy link

@subigre subigre commented Jun 19, 2024

Fix issue with volume ssh-git-creds (introduced in #710) that prevents to install master branch

optional: true was missing an indent

Signed-off-by: Renaud Subiger <renaud@subiger.com>
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

LGTM.

@jannfis jannfis merged commit f75d7dd into argoproj-labs:master Jun 19, 2024
9 checks passed
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
)

Signed-off-by: Renaud Subiger <renaud@subiger.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants