Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests: add unit tests for pkg/options.go and pkg/metrics.go #768

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

chengfang
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.81%. Comparing base (7f93ac5) to head (8b54ac8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
+ Coverage   61.72%   62.81%   +1.09%     
==========================================
  Files          31       31              
  Lines        3117     3117              
==========================================
+ Hits         1924     1958      +34     
+ Misses       1049     1015      -34     
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Cheng Fang <cfang@redhat.com>
Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis changed the title add unit tests for pkg/options.go and pkg/metrics.go tests: add unit tests for pkg/options.go and pkg/metrics.go Jul 5, 2024
@jannfis jannfis merged commit 3e7dc57 into argoproj-labs:master Jul 5, 2024
10 checks passed
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants