Allow Artifacts in argument dictionaries #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgunton
added
semver:patch
elliotgunton
force-pushed
the
arguments-fix
branch
2 times, most recently
from
c43ca54 to
3705be3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
=======================================
+ Coverage 86.3% 86.4% +0.1%
=======================================
Files 60 60
Lines 4095 4099 +4
Branches 653 651 -2
=======================================
+ Hits 3534 3543 +9
+ Misses 391 388 -3
+ Partials 170 168 -2 ☔ View full report in Codecov by Sentry. |
elliotgunton
force-pushed
the
arguments-fix
branch
from
9339362 to
f241b5c
Compare
elliotgunton
force-pushed
the
arguments-fix
branch
2 times, most recently
from
1f89535 to
93d03e8
Compare
elliotgunton
added
semver:minor
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
* Simplify list/creation appending * Move special Artifact test into its own test Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
elliotgunton
force-pushed
the
arguments-fix
branch
from
d4eeebe to
fd761a9
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently, only Parameters can be passed in dictionaries of arguments. This PR allows Artifacts to be passed in dictionaries, taking the key value as the new name of the Artifact (ignoring any
with_nameor originalnamevalues).Also refactored
_build_arguments, as promised 😎