Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add set-finallizer on argocd admin app generate-spec command #18855

Merged
merged 3 commits into from
Jun 30, 2024
Merged

feat: add set-finallizer on argocd admin app generate-spec command #18855

merged 3 commits into from
Jun 30, 2024

Conversation

KyriosGN0
Copy link
Contributor

@KyriosGN0 KyriosGN0 commented Jun 29, 2024 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Closes #17479

@KyriosGN0 KyriosGN0 requested a review from a team as a code owner June 29, 2024 20:39
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 29, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 29, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@KyriosGN0
added set-finallizer on argocd admin command
efc5d82 
Signed-off-by: AvivGuiser <aviv.guiser@placer.ai>
@KyriosGN0
ran make-codegen
e5e6674 
Signed-off-by: AvivGuiser <aviv.guiser@placer.ai>
@KyriosGN0 KyriosGN0 requested a review from a team as a code owner June 29, 2024 21:05
@codecov Codecov
Copy link

codecov bot commented Jun 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.36%. Comparing base (e6a0349) to head (8240652).
Report is 489 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/app.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #18855   +/-   ##
=======================================
  Coverage   50.35%   50.36%           
=======================================
  Files         315      315           
  Lines       43182    43189    +7     
=======================================
+ Hits        21746    21751    +5     
- Misses      18951    18954    +3     
+ Partials     2485     2484    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh
Copy link
Member

@KyriosGN0 please cover it with tests

@KyriosGN0
Copy link
Contributor Author

@pasha-codefresh, i don't see any testing of the NewGenAppSpecCommand that i added this functionaility to
i have tested locally and it works, if you could direct me on how to add the required test, i would greatly appreciate

@pasha-codefresh
Copy link
Member

Yeah, you are right, if you wish, you can write e2e test for this command. Otherwise let me know, i will do it by my own

@pasha-codefresh pasha-codefresh enabled auto-merge (squash) June 30, 2024 18:46
@pasha-codefresh pasha-codefresh merged commit 9b3a4d1 into argoproj:master Jun 30, 2024
26 checks passed
@KyriosGN0 KyriosGN0 deleted the feat/add-set-finalizer-to-argo-admin branch June 30, 2024 19:51
ggjulio pushed a commit to ggjulio/argo-cd that referenced this pull request Jul 21, 2024
@KyriosGN0 @pasha-codefresh @ggjulio
feat: add set-finallizer on argocd admin app generate-spec command (a…
8c955ee 
…rgoproj#18855)

* added set-finallizer on argocd admin command

Signed-off-by: AvivGuiser <aviv.guiser@placer.ai>

* ran make-codegen

Signed-off-by: AvivGuiser <aviv.guiser@placer.ai>

---------

Signed-off-by: AvivGuiser <aviv.guiser@placer.ai>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
jsolana pushed a commit to jsolana/argo-cd that referenced this pull request Jul 24, 2024
@KyriosGN0 @pasha-codefresh
feat: add set-finallizer on argocd admin app generate-spec command (a…
cd351ed 
…rgoproj#18855)

* added set-finallizer on argocd admin command

Signed-off-by: AvivGuiser <aviv.guiser@placer.ai>

* ran make-codegen

Signed-off-by: AvivGuiser <aviv.guiser@placer.ai>

---------

Signed-off-by: AvivGuiser <aviv.guiser@placer.ai>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: add flag --set-finalizer to argocd admin app generate-spec
2 participants
@KyriosGN0 @pasha-codefresh