Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: revert "feat: removed legacy app tracking label (#13203)" #19196

Merged
merged 3 commits into from
Jul 24, 2024
Merged

chore: revert "feat: removed legacy app tracking label (#13203)" #19196

merged 3 commits into from
Jul 24, 2024

Conversation

crenshaw-dev
Copy link
Member

Reverting this because Intuit's not able to do without this code yet. I'll plan to re-implement the change in 3.0.

@crenshaw-dev
Revert "feat: removed legacy app tracking label (argoproj#13203)"
b67f3b9 
This reverts commit 4d8436b.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner July 24, 2024 17:16
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jul 24, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jul 24, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

leoluz
leoluz approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 24, 2024 17:19
@crenshaw-dev
Copy link
Member Author

/cherry-pick release-2.12

@crenshaw-dev
lint
afc8738 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
fix test
2ce47a6 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev merged commit d0313c5 into argoproj:master Jul 24, 2024
27 of 28 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 24, 2024
@crenshaw-dev
Revert "feat: removed legacy app tracking label (#13203)" (#19196)
69c09dc 
This reverts commit 4d8436b.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 24, 2024
Merged
crenshaw-dev added a commit that referenced this pull request Jul 24, 2024
@gcp-cherry-pick-bot @crenshaw-dev
chore: revert "feat: removed legacy app tracking label (#13203)" (che…
d926310 
…rry-pick #19196)

This reverts commit 4d8436b.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
rhyswilliamsza pushed a commit to rhyswilliamsza/argo-cd that referenced this pull request Aug 12, 2024
@crenshaw-dev @rhyswilliamsza
Revert "feat: removed legacy app tracking label (argoproj#13203)" (ar…
9a4fd06 
…goproj#19196)

This reverts commit 4d8436b.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Rhys Williams <rhys.williams@electrum.co.za>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@leoluz leoluz leoluz approved these changes

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crenshaw-dev @leoluz @pasha-codefresh