fix: cherry-pick verify rbac permission in web terminal - 2.12 #19330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: verify rbac on each message and not just during handshake Signed-off-by: pashakostohrys <pavel@codefresh.io> * cover with tests Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix: linter and e2e tests Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix: linter and e2e tests Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> (cherry picked from commit e36248c)
crenshaw-dev
approved these changes
Jul 31, 2024
|
@ishitasequeira it was part of CVE , i cant find it in the list. Looks like it was deleted |
|
This is GHSA |
ishitasequeira
approved these changes
Jul 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-2.12 #19330 +/- ##
=============================================
Coverage 50.32% 50.33%
=============================================
Files 312 312
Lines 43097 43119 +22
=============================================
+ Hits 21689 21704 +15
- Misses 18920 18931 +11
+ Partials 2488 2484 -4 ☔ View full report in Codecov by Sentry. |
pasha-codefresh
merged commit d6c37aa
into
argoproj:release-2.12
22 of 24 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.