Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(rbac): allow validation of fine-grained policy in project #19338

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

agaudreault
Copy link
Member

@agaudreault agaudreault commented Aug 1, 2024

The support for fine-grained policies for update and delete was added with #18124, but it was impossible to configure the project via UI/API to configure these policies.

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault requested a review from a team as a code owner August 1, 2024 13:36
Copy link

bunnyshell bot commented Aug 1, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Aug 1, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault changed the title feat(rbac): allow validation of fine-grained policy in project fix(rbac): allow validation of fine-grained policy in project Aug 1, 2024
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.78%. Comparing base (60c53c6) to head (f89910a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19338      +/-   ##
==========================================
- Coverage   52.80%   52.78%   -0.02%     
==========================================
  Files         316      316              
  Lines       43587    43587              
==========================================
- Hits        23014    23008       -6     
  Misses      18024    18024              
- Partials     2549     2555       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 6ee5845 into argoproj:master Aug 1, 2024
30 of 31 checks passed
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.12

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Aug 1, 2024
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
crenshaw-dev pushed a commit that referenced this pull request Aug 1, 2024
… (#19339)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault deleted the project-rbac-validation branch August 1, 2024 14:39
rhyswilliamsza pushed a commit to rhyswilliamsza/argo-cd that referenced this pull request Aug 12, 2024
…roj#19338)

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Rhys Williams <rhys.williams@electrum.co.za>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants