feat: Add source namespaces output to printProject function #19344 #19365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19365 +/- ##
==========================================
+ Coverage 52.77% 52.79% +0.01%
==========================================
Files 316 316
Lines 43602 43608 +6
==========================================
+ Hits 23013 23021 +8
+ Misses 18033 18030 -3
- Partials 2556 2557 +1 ☔ View full report in Codecov by Sentry. |
juwon8891
changed the title
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
ishitasequeira
approved these changes
Aug 8, 2024
|
Thanks @juwon8891, appreciate it! |
ilia-medvedev-codefresh
pushed a commit
to ilia-medvedev-codefresh/argo-cd
that referenced
this pull request
Aug 13, 2024
…#19365) Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com> Signed-off-by: Ilia Medvedev <ilia.medvedev@codefresh.io>
reggie-k
pushed a commit
to reggie-k/argo-cd
that referenced
this pull request
Aug 14, 2024
…#19365) Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the printProject function to include the output of source namespaces.
Changes:
This enhancement improves the visibility of source namespaces in the project output, making it easier to review and debug project configurations.
Closed #19344