Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(appset): cherry-pick - fix appset-in-any-namespace issue with git generators #19558

Conversation

ishitasequeira
Copy link
Member

cherry-pick #19553 to release-2.12

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
@ishitasequeira ishitasequeira requested a review from a team as a code owner August 15, 2024 18:43
@ishitasequeira ishitasequeira changed the title fix appset-in-any-namespace issue with git generators fix(appset): fix appset-in-any-namespace issue with git generators Aug 15, 2024
@ishitasequeira ishitasequeira changed the title fix(appset): fix appset-in-any-namespace issue with git generators fix(appset): cherry-pick - fix appset-in-any-namespace issue with git generators Aug 15, 2024
Signed-off-by: Ishita Sequeira <ishiseq29@gmail.com>
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.33%. Comparing base (7af4526) to head (733d2a4).
Report is 1 commits behind head on release-2.12.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-2.12   #19558   +/-   ##
=============================================
  Coverage         50.32%   50.33%           
=============================================
  Files               312      312           
  Lines             43146    43150    +4     
=============================================
+ Hits              21715    21719    +4     
- Misses            18942    18946    +4     
+ Partials           2489     2485    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 952838c into argoproj:release-2.12 Aug 15, 2024
22 of 24 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants