fix: Parse hostname correctly from repoURL to fetch correct CA cert (cherry-pick #19488) #19602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…19488) Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Co-authored-by: Jann Fischer <jann@mistrust.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.12 #19602 +/- ##
================================================
+ Coverage 50.33% 50.34% +0.01%
================================================
Files 312 312
Lines 43150 43152 +2
================================================
+ Hits 21719 21726 +7
+ Misses 18945 18942 -3
+ Partials 2486 2484 -2 ☔ View full report in Codecov by Sentry. |
wanghong230
approved these changes
Aug 20, 2024
ishitasequeira
approved these changes
Aug 21, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: Parse hostname correctly from repoURL to fetch correct CA cert (#19488)
Signed-off-by: Siddhesh Ghadi sghadi1203@gmail.com
Co-authored-by: Jann Fischer jann@mistrust.net