Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(appset): Fix perpetual appset reconciliation #19822

Merged
merged 1 commit into from
Sep 13, 2024

Commits on Sep 12, 2024

  1. fix(appset): Fix perpetual appset reconciliation

    Golang maps do not guarantee the order of the application resources
    from the applicationset which causes rapid sync activity for the applicationset
    as the objects and hence their resourceVersions are updated after each reconcile loop.
    
    This then triggers reconciliation of all objects watching the
    ApplicationSet.
    
    In order to prevent this behaviour, ensure that the ApplicationSet
    reconciler provides an idempotent list of resources, ensuring objects
    are not updated.
    
    Fixes: argoproj#19757
    
    Co-authored-by: Fabian Selles <fabian.sellesrosa@gmail.com>
    Co-authored-by: Ariadna Rouco <ariadna.rouco@adevinta.com>
    Signed-off-by: Thibault Jamet <thibault.jamet@adevinta.com>
    Signed-off-by: Fabián Sellés <fabian.selles@adevinta.com>
    3 people authored and Thibault Jamet committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d39b7c7 View commit details
    Browse the repository at this point in the history