-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(ci): Allow forks to opt-in for codeql (#19993) #19996
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19996 +/- ##
==========================================
- Coverage 55.83% 55.82% -0.02%
==========================================
Files 320 320
Lines 44397 44397
==========================================
- Hits 24790 24783 -7
- Misses 17038 17054 +16
+ Partials 2569 2560 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Can you go ahead and fix the failing unit test check?
Signed-off-by: Josh Soref <jsoref@gmail.com>
I opened #20035 about the race. It's out of scope. We're working on removing the FOSSA check. |
Signed-off-by: Josh Soref <jsoref@gmail.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
Fixes #19993
Checklist: