Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(ci): Allow forks to opt-in for codeql (#19993) #19996

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

jsoref
Copy link
Member

@jsoref jsoref commented Sep 19, 2024

Fixes #19993

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jsoref jsoref requested review from a team as code owners September 19, 2024 01:57
Copy link

bunnyshell bot commented Sep 19, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 19, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.82%. Comparing base (6b6d23b) to head (273dc95).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19996      +/-   ##
==========================================
- Coverage   55.83%   55.82%   -0.02%     
==========================================
  Files         320      320              
  Lines       44397    44397              
==========================================
- Hits        24790    24783       -7     
- Misses      17038    17054      +16     
+ Partials     2569     2560       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Can you go ahead and fix the failing unit test check?

Signed-off-by: Josh Soref <jsoref@gmail.com>
@jsoref
Copy link
Member Author

jsoref commented Sep 20, 2024

I opened #20035 about the race. It's out of scope.

We're working on removing the FOSSA check.

@ishitasequeira ishitasequeira merged commit ddb79fe into argoproj:master Sep 22, 2024
27 of 28 checks passed
@jsoref jsoref deleted the issue-19993 branch September 23, 2024 00:21
ratulbasak pushed a commit to ratulbasak/argo-cd that referenced this pull request Sep 25, 2024
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow forks to opt-in for codeql
5 participants