Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(rbac): Add rights on applicationsets for the application controller #20352

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Oct 12, 2024

Upstream fix for: argoproj/argo-helm#2974

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@OpenGuidou OpenGuidou requested a review from a team as a code owner October 12, 2024 11:31
Copy link

bunnyshell bot commented Oct 12, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.60%. Comparing base (fa747f9) to head (a4efab1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20352      +/-   ##
==========================================
- Coverage   55.67%   55.60%   -0.08%     
==========================================
  Files         339      339              
  Lines       56814    56814              
==========================================
- Hits        31634    31590      -44     
- Misses      22535    22570      +35     
- Partials     2645     2654       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably don't want to do this: argoproj/argo-helm#2974 (comment)

@OpenGuidou
Copy link
Contributor Author

Updated to clarify the namespaced mode intent in the documentation

@OpenGuidou
Copy link
Contributor Author

@crenshaw-dev are you ok with the content now ?

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
@crenshaw-dev crenshaw-dev merged commit d1574c2 into argoproj:master Feb 6, 2025
27 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants