Skip to content

Commit

Permalink
Added option to disable the HTTPS service port (GKE)
Browse files Browse the repository at this point in the history
Signed-off-by: Marijn Blom <marijn@mainblades.com>
  • Loading branch information
MarijnMB committed Feb 8, 2025
1 parent f7b5090 commit 982ebd8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
6 changes: 3 additions & 3 deletions charts/argo-cd/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v2.14.2
kubeVersion: ">=1.25.0-0"
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 7.8.2
version: 7.8.3
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
sources:
Expand All @@ -26,5 +26,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: fixed
description: Create ServiceMonitor for dex only if dex is enabled
- kind: added
description: Option to disable the HTTPS service port
3 changes: 2 additions & 1 deletion charts/argo-cd/templates/argocd-server/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ spec:
{{- if eq .Values.server.service.type "NodePort" }}
nodePort: {{ .Values.server.service.nodePortHttp }}
{{- end }}
{{- if .Values.server.service.servicePortHttpsEnabled }}
- name: {{ .Values.server.service.servicePortHttpsName }}
protocol: TCP
port: {{ .Values.server.service.servicePortHttps }}
Expand All @@ -56,4 +57,4 @@ spec:
{{- end }}
selector:
{{- include "argo-cd.selectorLabels" (dict "context" . "name" .Values.server.name) | nindent 4 }}

{{- end }}
3 changes: 3 additions & 0 deletions charts/argo-cd/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2141,6 +2141,9 @@ server:
# -- Server service https port appProtocol
## Ref: https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol
servicePortHttpsAppProtocol: ""
# -- Enable the HTTPS service port (disable for GKE ingress)
## Ref: https://argo-cd.readthedocs.io/en/stable/operator-manual/ingress/#creating-a-service
servicePortHttpsEnabled: true
# -- The class of the load balancer implementation
loadBalancerClass: ""
# -- LoadBalancer will get created with the IP specified in this field
Expand Down

0 comments on commit 982ebd8

Please # to comment.