Skip to content

Commit

Permalink
chore: suggest non deprecated option
Browse files Browse the repository at this point in the history
Signed-off-by: chansuke <chansuke0@gmail.com>
  • Loading branch information
chansuke committed Jan 9, 2025
1 parent d963962 commit daa88bd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion charts/argo-workflows/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v3.6.2
name: argo-workflows
description: A Helm chart for Argo Workflows
type: application
version: 0.45.3
version: 0.45.4
icon: https://argo-workflows.readthedocs.io/en/stable/assets/logo.png
home: https://github.com/argoproj/argo-helm
sources:
Expand All @@ -18,3 +18,5 @@ annotations:
artifacthub.io/changes: |
- kind: added
description: Support ephemeral credentials for s3 artifact repository
- kind: fixed
description: Update the SSO configuration instructions to reflect the correct field name
2 changes: 1 addition & 1 deletion charts/argo-workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ Fields to note:
| server.sso.clientSecret.key | string | `"client-secret"` | Key of a secret to retrieve the app OIDC client secret |
| server.sso.clientSecret.name | string | `"argo-server-sso"` | Name of a secret to retrieve the app OIDC client secret |
| server.sso.customGroupClaimName | string | `""` | Override claim name for OIDC groups |
| server.sso.enabled | bool | `false` | Create SSO configuration. If you set `true` , please also set `.Values.server.authMode` as `sso`. |
| server.sso.enabled | bool | `false` | Create SSO configuration. If you set `true` , please also set `.Values.server.authModes` as `sso`. |
| server.sso.filterGroupsRegex | list | `[]` | Filter the groups returned by the OIDC provider |
| server.sso.insecureSkipVerify | bool | `false` | Skip TLS verification for the HTTP client |
| server.sso.issuer | string | `"https://accounts.google.com"` | The root URL of the OIDC identity provider |
Expand Down
2 changes: 1 addition & 1 deletion charts/argo-workflows/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ server:

# SSO configuration when SSO is specified as a server auth mode.
sso:
# -- Create SSO configuration. If you set `true` , please also set `.Values.server.authMode` as `sso`.
# -- Create SSO configuration. If you set `true` , please also set `.Values.server.authModes` as `sso`.
enabled: false
# -- The root URL of the OIDC identity provider
issuer: https://accounts.google.com
Expand Down

0 comments on commit daa88bd

Please # to comment.