fix(argo-workflows): fix helm lint error when extraObjects is defined #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workwithprashant
changed the title
Signed-off-by: workwithprashant <60788667+workwithprashant@users.noreply.github.com>
Signed-off-by: workwithprashant <60788667+workwithprashant@users.noreply.github.com>
workwithprashant
force-pushed
the
main
branch
from
3988f39 to
5456e6d
Compare
workwithprashant
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
yu-croco
reviewed
Dec 11, 2023
charts/argo-workflows/Chart.yaml
Outdated
| @@ -17,4 +17,4 @@ annotations: | |||
| url: https://argoproj.github.io/argo-helm/pgp_keys.asc | |||
| artifacthub.io/changes: | | |||
| - kind: changed | |||
| description: Add support for sso filterGroupsRegex according to https://argoproj.github.io/argo-workflows/argo-server-sso/#filtering-groups | |||
| description: fix(argo-workflows): fix helm lint error when extraObjects is defined and same fix as one done for argo-cd #2116 | |||
There was a problem hiding this comment.
Hi @workwithprashant ,thank you for your PR.
Please fix the failed lint.
Package lint FAILED. 1 error(s) occurred:
* invalid changes annotation. Please use quotes on strings that include any of the following characters: {}:[],&*#?|-<>=!%@
Otherwise LGTM. :)
Signed-off-by: workwithprashant <60788667+workwithprashant@users.noreply.github.com>
yu-croco
approved these changes
Dec 12, 2023
tico24
approved these changes
Dec 12, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: workwithprashant 60788667+workwithprashant@users.noreply.github.com
Checklist: