Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(argo-cd): add the requeue setting for appsets #3144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(argo-cd): add the requeue setting for appsets #3144

wants to merge 1 commit into from
+7 −1

Conversation

aburan28
Copy link

@aburan28 aburan28 commented Jan 27, 2025 •
edited
Loading

Simple PR that adds the option added in the following PR

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@aburan28
add the requeue setting for appsets
f68794b 
Signed-off-by: aburan28 <aburan28@gmail.com>
@aburan28 aburan28 changed the title add the requeue setting for appsets feat: add the requeue setting for appsets Jan 27, 2025
@aburan28 aburan28 changed the title feat: add the requeue setting for appsets feat(argo-cd): add the requeue setting for appsets Jan 27, 2025
@aburan28 aburan28 marked this pull request as ready for review January 27, 2025 23:00
@mkilchhofer mkilchhofer added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Jan 28, 2025
@mkilchhofer
Copy link
Member

Hi @aburan28, Thanks for your contribution.
While your mentioned PR is merged, it is not released (if you navigate to https://github.com/argoproj/argo-cd/blob/v2.13.3/manifests/base/applicationset-controller/argocd-applicationset-controller-deployment.yaml , you see that the ENV var is not yet present).

Therefore I add the awaiting-upstream label and we revisit your PR after we observe that the feature is now available inside a released version.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aburan28 @mkilchhofer