Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(argo-cd): Update to Argo CD 2.14 #3155

Merged
merged 11 commits into from
Feb 4, 2025
Merged

Conversation

mkilchhofer
Copy link
Member

@mkilchhofer mkilchhofer commented Feb 3, 2025

This is a late-night draft (😪) to replace the PR filed by Renovate:

Note to reviewers:

  • the new component commit-server is pretty new. The code was added "quick and dirty" by copy-paste of the upstream repo and add some basic customization options
  • Other components have some new env vars
  • Is the commit-server intended to be deployed by default or should we make it optional?

    image

  • Metrics customization is still open. I'd like to implement it in another PR, if you are okay with that?
    Basics are now there. But ServiceMonitor is still open.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
charts/argo-cd/values.yaml Outdated Show resolved Hide resolved
charts/argo-cd/values.yaml Show resolved Hide resolved
@@ -119,7 +119,8 @@ global:
priorityClassName: ""

# -- Default node selector for all components
nodeSelector: {}
nodeSelector:
kubernetes.io/os: linux
Copy link
Member Author

@mkilchhofer mkilchhofer Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change yes/no ?

Opinions from other maintainers ?

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
@mkilchhofer mkilchhofer marked this pull request as ready for review February 4, 2025 08:41
mbevc1
mbevc1 previously approved these changes Feb 4, 2025
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
@mkilchhofer mkilchhofer merged commit c77cb71 into main Feb 4, 2025
7 checks passed
@mkilchhofer mkilchhofer deleted the feature/argo-cd_2.14 branch February 4, 2025 11:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants