Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Remove client private key from client auth REST config #6506

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Aug 8, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #6506 (69ac03a) into master (8d60296) will increase coverage by 0.07%.
The diff coverage is 87.87%.

❗ Current head 69ac03a differs from pull request most recent head 96ee4d2. Consider uploading reports for the commit 96ee4d2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6506      +/-   ##
==========================================
+ Coverage   48.49%   48.57%   +0.07%     
==========================================
  Files         260      260              
  Lines       18804    18827      +23     
==========================================
+ Hits         9119     9145      +26     
+ Misses       8678     8674       -4     
- Partials     1007     1008       +1     
Impacted Files Coverage Δ
util/kubeconfig/kubeconfig.go 31.01% <87.87%> (+11.50%) ⬆️
cmd/argo/commands/get.go 58.30% <0.00%> (-0.59%) ⬇️
workflow/controller/operator.go 71.97% <0.00%> (-0.10%) ⬇️
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️
workflow/metrics/server.go 19.29% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d60296...96ee4d2. Read the comment docs.

@alexec alexec marked this pull request as ready for review August 8, 2021 04:39
@sarabala1979
Copy link
Member

I did the same fix but I am not sure about this is the right way to fix it. I am about to ask tomorrow.

@alexec alexec merged commit e2e822d into argoproj:master Aug 9, 2021
@alexec alexec deleted the no-mtls branch August 9, 2021 13:43
@sarabala1979 sarabala1979 mentioned this pull request Aug 11, 2021
28 tasks
sarabala1979 pushed a commit that referenced this pull request Aug 12, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added a commit that referenced this pull request Aug 13, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added a commit that referenced this pull request Aug 13, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants