Skip to content

Commit

Permalink
Remove unnesscary static tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ariselseng committed Feb 4, 2020
1 parent 5bdc33b commit 989e93c
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions tests/NorwegianBanksTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@

use Ariselseng\NorwegianBanks\NorwegianBanks;
use Ariselseng\NorwegianBanks\NorwegianBanksStatic;
use PHPUnit\Framework\TestCase;

class NorwegianBanksTest extends \PHPUnit\Framework\TestCase
class NorwegianBanksTest extends TestCase
{
private $norwegianBanks;
protected $notRealAccountNumber = '1234.56.78903';
Expand Down Expand Up @@ -36,19 +37,15 @@ public function setUp()
public function testGetFormattedAccountNumber()
{
$this->assertEquals($this->notRealAccountNumber, $this->norwegianBanks->getFormattedAccountNumber($this->notRealAccountNumberUnformatted));
$this->assertEquals($this->notRealAccountNumber, NorwegianBanksStatic::getFormattedAccountNumber($this->notRealAccountNumberUnformatted));
$this->assertEquals($this->notRealAccountNumberWithSpaces, $this->norwegianBanks->getFormattedAccountNumber($this->notRealAccountNumberUnformatted, ' '));
$this->assertEquals($this->notRealAccountNumberWithSpaces, NorwegianBanksStatic::getFormattedAccountNumber($this->notRealAccountNumberUnformatted, ' '));
}

public function testGetBankCodeByPrefix()
{
foreach ($this->accounts as $account) {
$this->assertEquals($account['bankCode'], $this->norwegianBanks->getBankCodeByPrefix(substr($account['number'], 0, 4)));
$this->assertEquals($account['bankCode'], NorwegianBanksStatic::getBankCodeByPrefix(substr($account['number'], 0, 4)));
}
$this->assertEquals(null, $this->norwegianBanks->getBankCodeByPrefix('0000'));
$this->assertEquals(null, NorwegianBanksStatic::getBankCodeByPrefix('0000'));
}

public function testGetBankByAccountNumber()
Expand All @@ -60,20 +57,16 @@ public function testGetBankByAccountNumber()
}

$this->assertEquals(null, $this->norwegianBanks->getBankByAccountNumber($this->notRealAccountNumber));
$this->assertEquals(null, NorwegianBanksStatic::getBankByAccountNumber($this->notRealAccountNumber));
}

public function testValidate()
{

foreach ($this->accounts as $account) {
$this->assertTrue($this->norwegianBanks->validateAccountNumber($account['number']));
$this->assertTrue(NorwegianBanksStatic::validateAccountNumber($account['number']));

}

$this->assertFalse($this->norwegianBanks->validateAccountNumber($this->notRealAccountNumber));
$this->assertFalse(NorwegianBanksStatic::validateAccountNumber($this->notRealAccountNumber));

}
}

0 comments on commit 989e93c

Please # to comment.