-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat(eos_designs,eos_cli_config_gen): Support for ipv6 addressing on network services VRFs #4222
base: devel
Are you sure you want to change the base?
Feat(eos_designs,eos_cli_config_gen): Support for ipv6 addressing on network services VRFs #4222
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4222
# Activate the virtual environment
source test-avd-pr-4222/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@vtep_diagnostic_eos_designs#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,vtep_diagnostic_eos_designs --force
# Optional: Install AVD examples
cd test-avd-pr-4222
ansible-playbook arista.avd.install_examples |
e7113a0
to
90ff525
Compare
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
95c1d9f
to
9635bd6
Compare
ansible_collections/arista/avd/examples/dual-dc-l3ls/documentation/devices/dc1-leaf1a.md
Outdated
Show resolved
Hide resolved
...ollections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/virtual-source-nat.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
01eead7
to
ac1e857
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/virtual-source-nat-vrfs.j2
Show resolved
Hide resolved
ac1e857
to
9208252
Compare
59e41f9
to
fb857ff
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/loopback_interfaces.py
Outdated
Show resolved
Hide resolved
…work_services.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…work_services.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…work_services.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…work_services.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…work_services.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…es/loopback_interfaces.py Co-authored-by: Claus Holbech <holbech@arista.com>
…es/loopback_interfaces.py Co-authored-by: Claus Holbech <holbech@arista.com>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Quality Gate passedIssues Measures |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@@ -311,6 +311,17 @@ def vrf_loopback_ip(self, pool: str) -> str: | |||
offset = self.shared_utils.id + self.shared_utils.loopback_ipv4_offset | |||
return get_ip_from_pool(pool, 32, offset, 0) | |||
|
|||
def vrf_loopback_ipv6(self, pool: str) -> str: | |||
""" | |||
Return IP address for a Loopback interface based on the given pool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return IP address for a Loopback interface based on the given pool. | |
Return IPv6 address for a Loopback interface based on the given pool. |
Change Summary
Add
ipv6 virtual source-nat vrf <vrf>
support to eos_cli_config_gen and eos_designs.Related Issue(s)
Fixes #3936 , #4207
Component(s) name
arista.avd.eos_designs
arista.avd.eos_cli_config_gen
Proposed changes
Added ipv6 support for virtual source nat vrfs.
How to test
Added test in molecule
Checklist
Repository Checklist